Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooling: add image compression #1647

Open
chalin opened this issue Aug 22, 2022 · 1 comment · May be fixed by #5412
Open

Tooling: add image compression #1647

chalin opened this issue Aug 22, 2022 · 1 comment · May be fixed by #5412
Labels
CI/infra CI & infrastructure p2-medium

Comments

@chalin
Copy link
Contributor

chalin commented Aug 22, 2022 •
edited
Loading

Originally posted by @mic-max in #869 (comment)

Making this part of the PR checks would be cool.
One way to implement it would be something like:

  1. The PR either modifies or creates a PNG
  2. Run a compression program on all the modified and created PNGs
  3. If all the compressed images have the same file sizes in the PR, succeed. Otherwise fail.

Then you'd likely want to add some guidance that before uploading they run the same compression program locally to a README
@chalin chalin added CI/infra CI & infrastructure p2-medium labels Aug 22, 2022
@mic-max
Copy link
Contributor

mic-max commented Aug 22, 2022

There is a GitHub app called ImgBot that does this that I recently discovered

@svrnm svrnm linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/infra CI & infrastructure p2-medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make language an enum in registry schema svrnm/opentelemetry.io
2 participants
@chalin @mic-max