Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make language an enum in registry schema #5412

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Oct 15, 2024

fixes #1647 by adding a gulp task that minifies all images. It also introduces a cache such that we can validate if images have been minified and fix it/check it via CI.

Note: This PR touches all images that's why there are 280 changed files. The relevant code is in gulp-src/image-min.js

@svrnm svrnm requested a review from a team as a code owner October 15, 2024 16:01
@opentelemetrybot opentelemetrybot requested review from a team and bogdandrutu and removed request for a team October 15, 2024 16:01
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm
Copy link
Member Author

svrnm commented Oct 16, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11365455104

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Tooling: add image compression
2 participants