Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instrumentation annotations reference #1651

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fix instrumentation annotations reference #1651

merged 1 commit into from
Aug 22, 2022

Conversation

jack-berg
Copy link
Member

Fixing typo.

@jack-berg jack-berg requested review from a team August 22, 2022 22:31
@jack-berg jack-berg mentioned this pull request Aug 22, 2022
Merged
@chalin chalin requested a review from trask August 22, 2022 22:34
@chalin
Copy link
Contributor

chalin commented Aug 22, 2022

/cc @mateuszrzeszutek @cartermp

chalin
chalin reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll let @trask give the final thumbs up.

trask
trask approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 👍

@chalin chalin merged commit 3e38802 into open-telemetry:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack-berg @chalin @trask