Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix malfunctioning configuration file #2148

Merged
merged 1 commit into from
Jan 10, 2023
Merged

chore: fix malfunctioning configuration file #2148

merged 1 commit into from
Jan 10, 2023

Conversation

TheJacobWalters
Copy link
Contributor

No description provided.

@TheJacobWalters TheJacobWalters requested review from a team and jpkrohling and removed request for a team January 9, 2023 22:18
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 9, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: TheJacobWalters / name: Jacob Walters (241d2ba)

@TheJacobWalters TheJacobWalters marked this pull request as draft January 9, 2023 22:22
@TheJacobWalters
Copy link
Contributor Author

closes #2147

cartermp
cartermp approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good catch, thank you

@cartermp
Copy link
Contributor

cartermp commented Jan 9, 2023

@TheJacobWalters if you'd like to get this merged feel free to move out of draft mode

@TheJacobWalters TheJacobWalters marked this pull request as ready for review January 10, 2023 14:24
@TheJacobWalters
Copy link
Contributor Author

@TheJacobWalters if you'd like to get this merged feel free to move out of draft mode

Ok, Ready for merge!

@svrnm svrnm merged commit 35732f1 into open-telemetry:main Jan 10, 2023
@svrnm
Copy link
Member

svrnm commented Jan 10, 2023

thanks @TheJacobWalters

@chalin chalin mentioned this pull request Feb 3, 2023
Closed
@nicholaschoi168 nicholaschoi168 mentioned this pull request May 19, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheJacobWalters @cartermp @svrnm @TylerHelmuth