Update Python agent-config #2272
Conversation
* Removing usage of `otlp_proto_grpc/http` * General fixes
| metrics are being exported to `console` (stdout). It is currently required for | ||
| your to specify a metrics exporter. If you aren't exporting metrics, specify | ||
| `none` as the value instead. |
There was a problem hiding this comment.
Not sure if it's still required to set a metrics exporter (probably not). Could also remove this part.
There was a problem hiding this comment.
At least as of last December it was needed (in my own testing). Otherwise you'd get an error at runtime. I'd love it if this isn't required anymore, though!
There was a problem hiding this comment.
Sorry for late reply -- I just confirmed that this is still necessary with the latest agent.
|
@open-telemetry/python-approvers , @open-telemetry/python-maintainers: PTAL |
content/en/docs/instrumentation/python/automatic/agent-config.md
Outdated
Show resolved
Hide resolved
content/en/docs/instrumentation/python/automatic/agent-config.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
|
/easycla |
|
@ronyis since you submitted this change, we've applied prettier-style formatting to the repo and added a check that's now failing. Would you mind running |
|
Sure, done @cartermp |
otlp_proto_grpc/http(as for deprecation)Preview: https://deploy-preview-2272--opentelemetry.netlify.app/docs/instrumentation/python/automatic/agent-config/