Add missing link to demo architecture diagram #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cartservice calls the featureflagservice.
chalin
force-pushed
the
demo-architecture-cartservice
branch
from
d8a5d64 to
9c5811e
Compare
reyang
approved these changes
Aug 15, 2023
|
@open-telemetry/demo-approvers it might be cool if we could automatically generate such diagram from distributed tracing data (e.g. let the demo run for 1 minute, collect spans, automatically populate the diagram and compare with the existing one so we know if there is new data path introduced) |
|
Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cartservice calls the featureflagservice (see open-telemetry/opentelemetry-demo#824). This adds a gRPC link between those services. I adjusted a couple link lengths to try to get a cleaner diagram.