-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand otel collector docs #3705
Conversation
…af intend for this to be squashed
31c3bc8
to
c9d0582
Compare
Thanks for sharing your work @hughesjj. As you said it's a big chunk to review, so I have to postpone the review for after the break |
Yup, it's also not in a reviewable state yet, I'll reach out when I feel it is. Thanks for letting me know =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! Thanks for this!
Could you explain a bit more the scope and purpose of the changes?
@@ -0,0 +1,15 @@ | |||
# Review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meant to be removed once the PR is ready, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this was me forcing myself to make some noise by the end of the year or else nothing will ever move. Sorry for any suffering caused by such
I put this together after our discussion today, lmk if the high level claim/plain makes sense to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will hold off opening an issue until we're in agreement
closing in favor of plan laid out in discussion |
I've had this kinda stuff sitting around for a while. It's a big chunk, so even though it's incomplete I figure I should at least start soliciting advice, sharing direction, or factoring out smaller bits to merge upstream.