Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand otel collector docs #3705

Closed
wants to merge 17 commits into from
Closed

Conversation

hughesjj
Copy link

I've had this kinda stuff sitting around for a while. It's a big chunk, so even though it's incomplete I figure I should at least start soliciting advice, sharing direction, or factoring out smaller bits to merge upstream.

@svrnm
Copy link
Member

svrnm commented Dec 22, 2023

I've had this kinda stuff sitting around for a while. It's a big chunk, so even though it's incomplete I figure I should at least start soliciting advice, sharing direction, or factoring out smaller bits to merge upstream.

Thanks for sharing your work @hughesjj. As you said it's a big chunk to review, so I have to postpone the review for after the break

@hughesjj
Copy link
Author

Yup, it's also not in a reviewable state yet, I'll reach out when I feel it is. Thanks for letting me know =)

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for this!

Could you explain a bit more the scope and purpose of the changes?

@@ -0,0 +1,15 @@
# Review
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to be removed once the PR is ready, I guess.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this was me forcing myself to make some noise by the end of the year or else nothing will ever move. Sorry for any suffering caused by such

I put this together after our discussion today, lmk if the high level claim/plain makes sense to you

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will hold off opening an issue until we're in agreement

@hughesjj
Copy link
Author

hughesjj commented Apr 8, 2024

closing in favor of plan laid out in discussion

@hughesjj hughesjj closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants