Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Collector architecture documentation and diagrams from Github to opentelemetry.io #4029
Move Collector architecture documentation and diagrams from Github to opentelemetry.io #4029
Changes from 4 commits
a9b4f7c
2236830
4b8eff0
87e96b2
e09a8bf
0a3184f
6072452
a84d8b6
1b7117e
3dcfa04
0a016d4
677af81
282fbf9
1cc36cd
8e12f26
d9858b7
64865d0
f3abc95
392906b
2740396
3a46360
ff7579f
ef248c2
d0aeb5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 62 in content/en/docs/collector/architecture.md
GitHub Actions / SPELLING check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this in a google doc and not in a markdown file in the collector repo? I guess this has historical reasons, maybe we can migrate it as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the document's origin, but I'm happy to convert it to Markdown and move it to the Collector repo if that's the consensus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question where this should live, this is up to the @open-telemetry/collector-approvers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove it altogether. It's so old that a few things are already wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in 2740396. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I count 11 more mentions of jaeger in the document, including several in diagrams (two of which I'm still working on).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need to remove all of them, only the instances where the jaeger exporter is used since it has been deprecated a while ago already, the receivers are still fine, but we still could consider using OTLP there. Jaeger can remain if named as a potential backend (which now supports OTLP)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed mentions of jaeger exporter to otlp in 8e12f26.
Check warning on line 187 in content/en/docs/collector/architecture.md
GitHub Actions / SPELLING check
Check warning on line 188 in content/en/docs/collector/architecture.md
GitHub Actions / SPELLING check
Check warning on line 234 in content/en/docs/collector/architecture.md
GitHub Actions / SPELLING check
Check warning on line 237 in content/en/docs/collector/architecture.md
GitHub Actions / SPELLING check