-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "using instrumentation libraries" for cpp #4388
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A first pass.
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8892505177 |
Co-authored-by: Severin Neumann <neumanns@cisco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this challenge @devc007!
@open-telemetry/cpp-approvers please take a look |
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@svrnm @theletterf sorry I don't know how to use local path, please can you help me |
@devc007 Hmmm. What do you need the "local path" for? |
This is to fix the following errors in CI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the documentation.
Please fix the URL reported by CI to use local path (../../somewhere/else
) instead of an absolute path (https:://same-website/full/path/to/somewhere/else
).
Looks good otherwise.
@devc007 best is to use the absolute path for local path, so |
You might miss some leading slashes in your links |
@marcalff minus the URL issues, is this PR good to go from @open-telemetry/cpp-approvers perspective? |
@theletterf @svrnm @marcalff Last time the URl's were creating problem and I have commited changes. Is there anything I need to improve? |
apologies for not following up earlier! The links are fixed, so I think we are good, @open-telemetry/cpp-approvers any concerns with merging? |
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9131113899 |
There are some strange bugs with EasyCLA: |
/easycla |
Thank you for your contribution and patience @devc007 |
Looking for the review to make this commit better.