-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go/getting-started.md #4577
Update go/getting-started.md #4577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good catch on the 5/21 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API has changed (as it can in a pre-v1 version), and WithInstrumentationScope
has been replaced by specific options (to remove the dependency on the SDK).
See open-telemetry/opentelemetry-go-contrib#5588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, request changes by mistake.
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9339355673 |
wooaaaahhh my god, okay, something in |
I am going to proceed with pushing this through for now, as it's not harmful and affecting other PRs. |
Some of the newly formatted lines look off to me, but I'm ok sticking to whatever Prettier provides. Thanks @cartermp. |
otelslog.WithInstrumentationScope
does not exist.