Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go/getting-started.md #4577

Merged
merged 4 commits into from
Jun 2, 2024

Conversation

ytnsym
Copy link
Contributor

@ytnsym ytnsym commented Jun 1, 2024

otelslog.WithInstrumentationScope does not exist.

@ytnsym ytnsym requested review from a team June 1, 2024 11:39
Copy link

linux-foundation-easycla bot commented Jun 1, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cartermp / name: Phillip Carter (d7f730e, 8ecc2bb)
  • ✅ login: opentelemetrybot / name: OpenTelemetry Bot (db2ba27)
  • ✅ login: ytnsym / name: yuta nishiyama (5d8b033)

@github-actions github-actions bot added the sig:go label Jun 1, 2024
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch on the 5/21 release

@cartermp cartermp added the sig-approval-missing Co-owning SIG didn't provide an approval label Jun 1, 2024
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API has changed (as it can in a pre-v1 version), and WithInstrumentationScope has been replaced by specific options (to remove the dependency on the SDK).
See open-telemetry/opentelemetry-go-contrib#5588

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, request changes by mistake.

@cartermp cartermp removed the sig-approval-missing Co-owning SIG didn't provide an approval label Jun 2, 2024
@cartermp
Copy link
Contributor

cartermp commented Jun 2, 2024

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9339355673

@github-actions github-actions bot requested review from a team and removed request for a team June 2, 2024 15:26
@github-actions github-actions bot requested a review from songy23 June 2, 2024 15:26
@cartermp
Copy link
Contributor

cartermp commented Jun 2, 2024

wooaaaahhh my god, okay, something in main or our formatter changed that led to the formatter not being happy, sorry for the mass notification everyone

@cartermp cartermp removed request for a team and songy23 June 2, 2024 15:29
@cartermp
Copy link
Contributor

cartermp commented Jun 2, 2024

This might be a consequence of https://prettier.io/blog/2024/06/01/3.3.0#improve-wrapping-for-markdown--mdx-16158httpsgithubcomprettierprettierpull16158-by-seiyabhttpsgithubcomseiyab

cc @chalin

@cartermp
Copy link
Contributor

cartermp commented Jun 2, 2024

I am going to proceed with pushing this through for now, as it's not harmful and affecting other PRs.

@cartermp cartermp merged commit aa67a24 into open-telemetry:main Jun 2, 2024
5 checks passed
@chalin
Copy link
Contributor

chalin commented Jun 2, 2024

Some of the newly formatted lines look off to me, but I'm ok sticking to whatever Prettier provides. Thanks @cartermp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants