Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Ensure fallback pages have en lang #4683

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 14, 2024

Before and after

$ curl -s https://opentelemetry.io/ja/docs/getting-started/ | perl -nle 'print $1 if /html[^>]*(lang=\S+)/i' 
lang=ja
$ curl -s https://deploy-preview-4683--opentelemetry.netlify.app/ja/docs/getting-started/ | perl -nle 'print $1 if /html[^>]*(lang=\S+)/i' 
lang=en

Preview

@chalin chalin added enhancement New feature or request i18n internationalization labels Jun 14, 2024
@chalin chalin requested a review from a team June 14, 2024 08:23
@chalin chalin force-pushed the chalin-im-i18n-lang-fix-2024-06-12 branch from 101fb66 to c6a09fe Compare June 14, 2024 09:11
@chalin chalin merged commit 3b44fbf into open-telemetry:main Jun 14, 2024
16 checks passed
@chalin chalin deleted the chalin-im-i18n-lang-fix-2024-06-12 branch June 14, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i18n internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] Ensure that fallback pages have en lang attribute
2 participants