-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document some quirks with Python otel operator based auto-instrumentation #5338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions.
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11237644963 |
fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11237644963. |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11254563117 |
fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11254563117. |
It's openai.com returning 403, maybe they started blocking connections from github? Or some stale cache? |
This was introduced with merging the semconv update, rebasing the PR should fix it |
Co-authored-by: Fabrizio Ferri-Benedetti <algernon@fastmail.com>
Co-authored-by: Fabrizio Ferri-Benedetti <algernon@fastmail.com>
8b6b048
to
763d24d
Compare
@svrnm thanks! |
@theletterf can you take a look if your change requestd have been applied as suggested and if so approve? thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few copy edit changes. Thanks!
Some Python packages we instrument or need in our instrumentation libraries, | ||
might ship with some binary code. This is the case, for example, of `grpcio` and | ||
`psutil` (used in `opentelemetry-instrumentation-system-metrics`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Python packages we instrument or need in our instrumentation libraries, | |
might ship with some binary code. This is the case, for example, of `grpcio` and | |
`psutil` (used in `opentelemetry-instrumentation-system-metrics`). | |
Some Python packages we instrument or need in our instrumentation libraries | |
might ship with some binary code. This is the case, for example, with `grpcio` and | |
`psutil`, which are used in `opentelemetry-instrumentation-system-metrics`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only psutil is used in the system metrics package, grpcio is used generally in the exporters or in its own instrumentation library.
want to use it you might need to build your own image operator Docker image for | ||
Python auto-instrumentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to use it you might need to build your own image operator Docker image for | |
Python auto-instrumentation. | |
want to use it, you might need to build your own image operator Docker image for | |
Python autoinstrumentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's spelled auto-instrumentation in other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly we have an issue for fixing that at once, I think it is fine to keep it that way
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Fix #5243