Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom-collector.md #5363

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Update custom-collector.md #5363

merged 1 commit into from
Oct 11, 2024

Conversation

jackgopack4
Copy link
Contributor

update providers in builder-config.yaml to match stable versions.

Per https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.111.0, more providers are marked as stable. Updating custom collector documentation to use the latest stable components by default

update providers in builder-config.yaml to match stable versions
@jackgopack4 jackgopack4 requested a review from a team as a code owner October 9, 2024 14:41
@opentelemetrybot opentelemetrybot requested review from a team and codeboten and removed request for a team October 9, 2024 14:41
@cartermp cartermp added the sig-approval-missing Co-owning SIG didn't provide an approval label Oct 10, 2024
@svrnm
Copy link
Member

svrnm commented Oct 10, 2024

I just wanted to suggest that we use the versions from the registry for those entries as well, but then I saw that the providers are not in the registry. I wonder if we should add them? cc @mx-psi, since we discussed this here: #5304 (comment)

@mx-psi
Copy link
Member

mx-psi commented Oct 11, 2024

I think confmap providers should be added to the registry: they are conceptually similar to other kinds of components in the Collector in that they provide extra functionality to the Collector, can be added on a Collector builder manifest, can be 'official' or come from a third-party repository...

@svrnm
Copy link
Member

svrnm commented Oct 11, 2024

I think confmap providers should be added to the registry: they are conceptually similar to other kinds of components in the Collector in that they provide extra functionality to the Collector, can be added on a Collector builder manifest, can be 'official' or come from a third-party repository...

then let's do that, in the meantime, would you mind approving this PR, so we have it up-to-date and then we add them to the registry?

@svrnm svrnm added this pull request to the merge queue Oct 11, 2024
Merged via the queue into open-telemetry:main with commit 9b7da35 Oct 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig:collector sig-approval-missing Co-owning SIG didn't provide an approval
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants