✅ [OUTREACHY] : Mobile UI optimization #5403
Conversation
kemsguy7
changed the title
|
@svrnm , please kindly review |
assets/scss/_registry.scss
Outdated
| @@ -9,7 +9,7 @@ | |||
| @each $component, $color in $otel-registry-license-colors { | |||
| &.badge-#{$component} { | |||
| color: white; | |||
| background-color: $color; | |||
| background-color: $color; | |||
There was a problem hiding this comment.
| background-color: $color; | |
| background-color: $color; |
There was a problem hiding this comment.
@svrnm do i add a space here too?
|
@svrnm , i've applied a fix to this issue, kindly find attached a screenshot
|
| </li> | ||
| {{ end -}} | ||
| {{ end -}} |
There was a problem hiding this comment.
| {{ end -}} | |
| {{ end -}} | |
There was a problem hiding this comment.
@svrnm please what fix exactly do you need here? the linting?
There was a problem hiding this comment.
Add an empty line at the bottom of the file
There was a problem hiding this comment.
Note that you might be able to auto fix that by running npm run:format locally
There was a problem hiding this comment.
oh! @svrnm , thanks for this. I'm on it.
svrnm
changed the title
|
Minor issue, but beyond that this looks good! When you have applied that minor change, I consider this as done! After the outreachy application phase we will take another look and see if we can merge this PR. |
| </li> | ||
| {{ end -}} | ||
| {{ end -}} |
There was a problem hiding this comment.
| {{ end -}} | |
| {{ end -}} |
This pr resolves issue: #5318 where i resolved some ux issues on the mobile view of the registry page.
Key changes
Demo
mobile-optimization-open-telm.mp4