Instrumentation page #5523
Instrumentation page #5523
Conversation
There was a problem hiding this comment.
Move this file to the folder content/en/docs/concepts/instrumentation
|
|
||
|
|
There was a problem hiding this comment.
Removing both lines takes it back to the original (looks better) so let me go with that. Thank you
| @@ -5,6 +5,8 @@ aliases: [instrumenting] | |||
| weight: 15 | |||
| --- | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
update this with the right URL after you have moved the file to the right location
| @@ -5,6 +5,8 @@ aliases: [instrumenting] | |||
| weight: 15 | |||
| --- | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
|  | |
|  |
There was a problem hiding this comment.
The original issue:
said to move the image. So you also need to delete it from https://github.com/open-telemetry/opentelemetry.io/blob/main/static/img/libraries-instrumentation.svg.
There was a problem hiding this comment.
Please trim out the excessive whitespace around the image content.
There was a problem hiding this comment.
Also, consider renaming this file native-vs-libraries.svg.
There was a problem hiding this comment.
I trimmed the excessive whitespace around the image content and renamed the file to native-vs-libraries.svg. Please let me know if you need any further adjustments.
|
@DIANAAJAMBO please take a look at this comment: #5523 (comment) |
Hello @svrnm , I made this change in my last commit, as seen here: https://github.com/open-telemetry/opentelemetry.io/pull/5523/files. However, the original image referenced was merged into the main repository, and I currently lack the necessary rights to update it. |
You copied the file but you didn't move the file: https://github.com/DIANAAJAMBO/opentelemetry.io/blob/librariesPage/static/img/libraries-instrumentation.svg is still existing, so what you need to do is to remove that file and then commit that as a change, git(hub) will then detect that this is a move. |
Okay thank you. I will implement this today. |
DIANAAJAMBO
force-pushed
the
librariesPage
branch
from
fa220d3 to
3a7b057
Compare
@svrnm All should be okay now. Help me review. Thanks |
There was a problem hiding this comment.
shouldn't this be content/en/docs/concepts/instrumentation/libraries.md ?
There was a problem hiding this comment.
Can you make sure that this image also work in darmkode, e.g. remove the white background and choose a different color for the "vs" so it is visible on light and dark backgrounds
There was a problem hiding this comment.
@svrnm & @DIANAAJAMBO - thinking about this more: how about putting this information in a table rather than an SVG? It would be easier to consult, visualize, and render (e.g., dark-mode would be handled automatically; no need to putts around with the SVG colors). WDYT?
Moved an image from the libraries page to the instrumentation page.