-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move performance to java agent, merge javadoc into API page #5590
Conversation
b6cb1b9
to
c8356da
Compare
c8356da
to
179b145
Compare
/fix:htmltest-config |
You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11808233847 |
IMPORTANT: (RE-)RUN
|
179b145
to
bf1372f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. @open-telemetry/docs-approvers any other feedback?
Once all checks are passing, of course ✅
bf1372f
to
67786e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until I figure out how best to manage the broken links in non-en pages.
(Edited to include a full list) @jack-berg - there are broken links in this
|
…elemetry.io into shift-java-pages
I've fixed all the links and believe there weren't any broken links in non-en pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will wait for @chalin to re-review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the non-en link-check failures were in en fallback pages.
LGTM
It seems that we need one more approval from @open-telemetry/java-approvers. |
We've got an approval from java-approver @jaydeluca. Do we need a second? In the past, one java-approver approval has been enough. Not expressing an opinion on whether we should have one or two approvals required - just clarifying my understanding. 🙂 |
I'm not sure what the policy is; I'll let @svrnm chime in. Also, I don't see @jaydeluca listed in @open-telemetry/java-approvers, which matches what GH reported above: |
Ah that's right. Yeah we have a bit of a weird thing going on where we have two partially independent / partially overlapping groups of approvers in the java SIG: @open-telemetry/java-approvers and @open-telemetry/java-instrumentation-approvers. Both groups are trusted collaborators in the Java SIG, but the @open-telemetry/java-instrumentation-approvers tend to contribute more to the In my head, the set of people trusted to approve java opentelemetry.io PRs is the superset of both groups, since the docs have much less strict delineation between content related to Some instances where an approval from a @open-telemetry/java-instrumentation-approvers has been sufficient: #5471, #5275, #4966 |
Thanks for the explanation @jack-berg. That works for me. Adding this to the merge queue. |
👍 |
…emetry#5590) Co-authored-by: Patrice Chalin <pchalin@gmail.com>
Resolves #5211.
An alternative to #5522 based on the conversation here:
Previews