Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo] Add Cart service exemplars doc #5788

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[demo] Add Cart service exemplars doc #5788

wants to merge 4 commits into from

Conversation

julianocosta89
Copy link
Member

This PR adds documentation to the Exemplars added to the Cart service in the Demo.

It depends on the following issues to be merged:

@julianocosta89 julianocosta89 requested a review from a team as a code owner December 13, 2024 12:48
@opentelemetrybot opentelemetrybot requested a review from a team December 13, 2024 12:48
@julianocosta89
Copy link
Member Author

npm run fix:htmltest-config is not changing anything 🤔

puckpuck
puckpuck approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One grammar nitpick, but this looks great otherwise.

@julianocosta89 @puckpuck
Apply suggestion
133b563 
Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
@opentelemetrybot opentelemetrybot requested a review from a team December 14, 2024 07:47
@julianocosta89
Copy link
Member Author

I need to update the screenshot based on @puckpuck's change in the Dashboard

chalin
chalin requested changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the image is specific to the cart service, I suggest the following:

  • Create content/en/docs/demo/services/cart/
  • Move and rename content/en/docs/demo/services/cart.md to content/en/docs/demo/services/cart/index.md
  • Move and rename content/en/docs/demo/screenshots/cart-service-exemplars.png to content/en/docs/demo/services/cart/exemplars.png
  • Adjust the in-page link to the image: ![Cart Service Exemplars](exemplars.png)

/cc @svrnm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin requested changes

@puckpuck puckpuck puckpuck approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
sig:demo
Projects
SIG Comms: PRs & Issues
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianocosta89 @puckpuck @chalin