Add native library instrumentation guidance #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking for early feedback on the native library instrumentation doc. /cc @tedsuo |
lmolkova
changed the title
SergeyKanzhelev
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
lgtm in general, couple suggestions. There are sitll quite a few TODO, but looks good as an initial version with the placeholder. If it will be merged, I'd suggest to replace "TODO" with "Under Constructions" node and emoji 🚧, so it will be reader-friendly - indicating there is work ongoing rather than the article is incomplete.
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
|
Thanks @SergeyKanzhelev |
lmolkova
force-pushed
the
native-instrumentation
branch
2 times, most recently
from
0c8dafb
to
c8ec685
Compare
lmolkova
force-pushed
the
native-instrumentation
branch
from
c8ec685
to
742ee79
Compare
austinlparker
approved these changes
Oct 1, 2021
|
thanks @austinlparker ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.