Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exporters & instrumentation for otel-cpp to registry. #892

Merged
merged 11 commits into from
Nov 11, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 10, 2021

@lalitb lalitb requested a review from a team November 10, 2021 03:37
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language field value should be cpp, per

{{ $languages.Set "cpp" "C++" -}}

Otherwise, these entries don't show up in the registry as you can see this PR's preview https://deploy-preview-892--opentelemetry.netlify.app/registry/?s=&component=all&language=cpp#

@chalin
Copy link
Contributor

chalin commented Nov 11, 2021

Let me know if you'd like me to make the changes @lalitb.

@lalitb
Copy link
Member Author

lalitb commented Nov 11, 2021

Let me know if you'd like me to make the changes @lalitb.

Thanks @chalin if you can do so, else I will take it during my morning.

@chalin
Copy link
Contributor

chalin commented Nov 11, 2021

Thanks @chalin if you can do so, else I will take it during my morning.

I'm on it.

@chalin
Copy link
Contributor

chalin commented Nov 11, 2021

Apologies for the extra comments that have appeared: I was trying to edit the PR via github.dev, but it wouldn't let me commit the changes, so I fall back to editing each file individually (the only way I could get the changes in without submitting a new PR).

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language fields updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants