-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exporters & instrumentation for otel-cpp to registry. #892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language
field value should be cpp
, per
{{ $languages.Set "cpp" "C++" -}} |
Otherwise, these entries don't show up in the registry as you can see this PR's preview https://deploy-preview-892--opentelemetry.netlify.app/registry/?s=&component=all&language=cpp#
Let me know if you'd like me to make the changes @lalitb. |
I'm on it. |
Apologies for the extra comments that have appeared: I was trying to edit the PR via github.dev, but it wouldn't let me commit the changes, so I fall back to editing each file individually (the only way I could get the changes in without submitting a new PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language fields updated
Preview: https://deploy-preview-892--opentelemetry.netlify.app/registry/?s=&component=all&language=cpp#