Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return nil from Server on stream shutdown #24

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Return nil from Server on stream shutdown #24

merged 5 commits into from
Aug 31, 2023

Commits on Aug 29, 2023

  1. return nil on EOF

    @moh-osman3
    moh-osman3 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f7855c7 View commit details
    Browse the repository at this point in the history

  2. revert replay.yaml

    @moh-osman3
    moh-osman3 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    da19871 View commit details
    Browse the repository at this point in the history

  3. send ok with id -1 for clean shutdown

    @moh-osman3
    moh-osman3 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a4ca19f View commit details
    Browse the repository at this point in the history

  4. address review feedback

    @moh-osman3
    moh-osman3 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    07670a2 View commit details
    Browse the repository at this point in the history

  5. fix test

    @moh-osman3
    moh-osman3 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3aa56a4 View commit details
    Browse the repository at this point in the history