Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columnar encoding for the OpenTelemetry protocol #171

Merged
merged 142 commits into from
Jun 29, 2023
Merged

Columnar encoding for the OpenTelemetry protocol #171

merged 142 commits into from
Jun 29, 2023

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Aug 10, 2021

Ongoing experiments, research, and draft specification for a multi-variate columnar encoding of OTLP.

At the request of @jmacd

@lquerel lquerel requested a review from a team August 10, 2021 23:11
lquerel and others added 5 commits June 26, 2023 07:59
Co-authored-by: Antoine Toulme <antoine@toulme.name>
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
Co-authored-by: Antoine Toulme <antoine@toulme.name>
Co-authored-by: Antoine Toulme <antoine@toulme.name>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor wording suggestions.

lquerel and others added 3 commits June 26, 2023 12:26
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
lquerel and others added 2 commits June 26, 2023 12:31
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
@reyang
Copy link
Member

reyang commented Jun 26, 2023

@jsuereth @zeroshade @mbrobbel @itaykat could you take another look and see if there is anything blocking? If not, I suggest that we give the PR few more days and merge it by end of this week (6/30/2023).

@reyang reyang merged commit 168eb91 into open-telemetry:main Jun 29, 2023
Copy link

@jgehrcke jgehrcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dyladan
Copy link
Member

dyladan commented Jul 6, 2023

The GC voted to accept the donation (open-telemetry/community#1332) on July 6 2023

@infogulch
Copy link

Did we ever get results back on the Phase 2 multivariate time series tests?

For multivariate time series, OTel Arrow is 3 to 7 times better in terms of bandwidth reduction while having an end-to-end speed (including conversion to/from OTLP) similar to the univariate time series scenario phase 1. Phase 2 has been yet estimated but similar results are expected.

@lquerel
Copy link
Contributor Author

lquerel commented Aug 28, 2023

@infogulch - The current implementation (Phase 1) includes optimizations for multivariate metrics, which are presented as a set of univariate metrics. We've observed a compression ratio enhancement ranging from 3x to 7x with this setup. Phase 2, which is yet to start, will deepen this support for multivariate metrics, integrating them not just at the protocol layer but also within the client SDK API. I aim to release a beta version of this extended client SDK by the end of the year.
I am, in any case, interested in learning more about your use case if possible, to refine my response if necessary.

@infogulch
Copy link

I see, thank you for clarifying. I didn't understand that the phase 2 tests are still in process.

Personally I've been watching otel for a while but am not currently using it; my comment came from a fleeting curiosity about the intersection of telemetry and column-oriented storage/processing formats from the recent hn thread about otel, where someone kindly forwarded me here. From this report it seems they work together quite nicely! (I love when incidental ideas are confirmed by someone that put in the work to test it 6 months ago!)

Thank you for your attention, sorry for the noise, and good luck integrating columnar layouts into otel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed Projects
Development

Successfully merging this pull request may close these issues.