This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
Propose: Remove support to report out-of-band telemetry from the API #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
AloisReitbauer,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
jmacd
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
This is a good step towards our 1.0 goals. We can always add something like this in the future. For now, if a user wants to alter the resources they can construct alternate SDKx, later we can evaluate how much complexity is introduced if individual spans and metrics operations can vary resources.
songy23
approved these changes
Aug 27, 2019
bg451
approved these changes
Aug 27, 2019
lizthegrey
approved these changes
Aug 27, 2019
Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
alban
added a commit
to kinvolk/opentelemetry-python
that referenced
this pull request
Aug 28, 2019
OTEP-7 ("Remove support to report out-of-band telemetry from the API")
states that the API does not support specifying the span_id in
create_span() or start_span(). Also, following OTEP-2 ("Remove
SpanData"), we cannot use the SpanData to specify the span_id.
However, the need to specify the span_id remains for some applications.
Following the suggestion from OTEP-7, I am adding this feature in the
SDK only.
This patch adds the named argument span_id in create_span() and
start_span() to optionally specify the id of the span to be created.
When unset, the previous behavior remains and the SDK allocate a span_id
automatically.
Callers should give the name of the argument and not rely on the
current argument order because more arguments could be passed in the
future. OTEP-2 lists possible additional optional arguments:
- start timestamp
- span ID
- resource
Example of call:
with tracer.start_span('foo', span_id = my_span_id):
print(Context)
OTEP-7: open-telemetry/oteps#26
OTEP-2: https://github.com/open-telemetry/oteps/blob/master/text/0002-remove-spandata.md
alban
added a commit
to kinvolk/opentelemetry-python
that referenced
this pull request
Aug 28, 2019
OTEP-7 ("Remove support to report out-of-band telemetry from the API")
states that the API does not support specifying the span_id in
create_span() or start_span(). Also, following OTEP-2 ("Remove
SpanData"), we cannot use the SpanData to specify the span_id.
However, the need to specify the span_id remains for some applications.
Following the suggestion from OTEP-7, I am adding this feature in the
SDK only.
This patch adds the named argument span_id in create_span() and
start_span() to optionally specify the id of the span to be created.
When unset, the previous behavior remains and the SDK allocates a
span_id automatically.
Callers should give the name of the argument and not rely on the
current argument order because more arguments could be passed in the
future. OTEP-2 lists possible additional optional arguments:
- start timestamp
- span ID
- resource
Example of call:
```
with tracer.start_span('foo', span_id = my_span_id):
print(Context)
```
OTEP-7: open-telemetry/oteps#26
OTEP-2: https://github.com/open-telemetry/oteps/blob/master/text/0002-remove-spandata.md
alban
added a commit
to kinvolk/opentelemetry-python
that referenced
this pull request
Aug 28, 2019
OTEP-7 ("Remove support to report out-of-band telemetry from the API")
states that the API does not support specifying the span_id in
create_span() or start_span(). Also, following OTEP-2 ("Remove
SpanData"), we cannot use the SpanData to specify the span_id.
However, the need to specify the span_id remains for some applications.
Following the suggestion from OTEP-7, I am adding this feature in the
SDK only.
This patch adds the named argument span_id in create_span() and
start_span() to optionally specify the id of the span to be created.
When unset, the previous behavior remains and the SDK allocates a
span_id automatically.
Callers should give the name of the argument and not rely on the
current argument order because more arguments could be passed in the
future. OTEP-2 lists possible additional optional arguments:
- start timestamp
- span ID
- resource
Example of call:
```
with tracer.start_span('foo', span_id=my_span_id):
print(Context)
```
OTEP-7: open-telemetry/oteps#26
OTEP-2: https://github.com/open-telemetry/oteps/blob/master/text/0002-remove-spandata.md
alban
added a commit
to kinvolk/opentelemetry-python
that referenced
this pull request
Aug 28, 2019
OTEP-7 ("Remove support to report out-of-band telemetry from the API")
states that the API does not support specifying the span_id in
create_span() or start_span(). Also, following OTEP-2 ("Remove
SpanData"), we cannot use the SpanData to specify the span_id.
However, the need to specify the span_id remains for some applications.
Following the suggestion from OTEP-7, I am adding this feature in the
SDK only.
This patch adds the named argument span_id in create_span() and
start_span() to optionally specify the id of the span to be created.
When unset, the previous behavior remains and the SDK allocates a
span_id automatically.
Callers should give the name of the argument and not rely on the
current argument order because more arguments could be passed in the
future. OTEP-2 lists possible additional optional arguments:
- start timestamp
- span ID
- resource
Example of call:
```
with tracer.start_span('foo', span_id=my_span_id):
print(Context)
```
OTEP-7: open-telemetry/oteps#26
OTEP-2: https://github.com/open-telemetry/oteps/blob/master/text/0002-remove-spandata.md
alban
added a commit
to kinvolk/opentelemetry-python
that referenced
this pull request
Aug 28, 2019
OTEP-7 ("Remove support to report out-of-band telemetry from the API")
states that the API does not support specifying the span_id in
create_span() or start_span(). Also, following OTEP-2 ("Remove
SpanData"), we cannot use the SpanData to specify the span_id.
However, the need to specify the span_id remains for some applications.
Following the suggestion from OTEP-7, I am adding this feature in the
SDK only.
This patch adds the named argument span_id in create_span() and
start_span() to optionally specify the id of the span to be created.
When unset, the previous behavior remains and the SDK allocates a
span_id automatically.
Callers should give the name of the argument and not rely on the
current argument order because more arguments could be passed in the
future. OTEP-2 lists possible additional optional arguments:
- start timestamp
- span ID
- resource
Example of call:
```
with tracer.start_span('foo', span_id=my_span_id):
print(Context)
```
OTEP-7: open-telemetry/oteps#26
OTEP-2: https://github.com/open-telemetry/oteps/blob/master/text/0002-remove-spandata.md
alban
added a commit
to kinvolk/opentelemetry-python
that referenced
this pull request
Aug 28, 2019
OTEP-7 ("Remove support to report out-of-band telemetry from the API")
states that the API does not support specifying the span_id in
create_span() or start_span(). Also, following OTEP-2 ("Remove
SpanData"), we cannot use the SpanData to specify the span_id.
However, the need to specify the span_id remains for some applications.
Following the suggestion from OTEP-7, I am adding this feature in the
SDK only.
This patch adds the named argument span_id in create_span() and
start_span() to optionally specify the id of the span to be created.
When unset, the previous behavior remains and the SDK allocates a
span_id automatically.
Callers should give the name of the argument and not rely on the
current argument order because more arguments could be passed in the
future. OTEP-2 lists possible additional optional arguments:
- start timestamp
- span ID
- resource
Example of call:
```
with tracer.start_span('foo', span_id=my_span_id):
print(Context)
```
OTEP-7: open-telemetry/oteps#26
OTEP-2: https://github.com/open-telemetry/oteps/blob/master/text/0002-remove-spandata.md
alban
added a commit
to kinvolk/opentelemetry-python
that referenced
this pull request
Aug 28, 2019
OTEP-7 ("Remove support to report out-of-band telemetry from the API")
states that the API does not support specifying the span_id in
create_span() or start_span(). Also, following OTEP-2 ("Remove
SpanData"), we cannot use the SpanData to specify the span_id.
However, the need to specify the span_id remains for some applications.
Following the suggestion from OTEP-7, I am adding this feature in the
SDK only.
This patch adds the named argument span_id in create_span() and
start_span() to optionally specify the id of the span to be created.
When unset, the previous behavior remains and the SDK allocates a
span_id automatically.
Callers should give the name of the argument and not rely on the
current argument order because more arguments could be passed in the
future. OTEP-2 lists possible additional optional arguments:
- start timestamp
- span ID
- resource
Example of call:
```
with tracer.start_span('foo', span_id=my_span_id):
print(Context)
```
OTEP-7: open-telemetry/oteps#26
OTEP-2: https://github.com/open-telemetry/oteps/blob/master/text/0002-remove-spandata.md
tedsuo
approved these changes
Sep 1, 2019
carlosalberto
approved these changes
Sep 2, 2019
discostu105
approved these changes
Sep 3, 2019
|
Please rebase. |
|
Any objections for this PR? In order to merge this we need couple more approves. |
c24t
approved these changes
Sep 11, 2019
This was referenced Oct 21, 2019
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
…n-telemetry#26) * Propose: Remove support to report out-of-band telemetry from the API * Clarify what the change means * Update text/0007-no-out-of-band-reporting.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com> * Update text/0007-no-out-of-band-reporting.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
…n-telemetry#26) * Propose: Remove support to report out-of-band telemetry from the API * Clarify what the change means * Update text/0007-no-out-of-band-reporting.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com> * Update text/0007-no-out-of-band-reporting.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 30, 2024
…n-telemetry#26) * Propose: Remove support to report out-of-band telemetry from the API * Clarify what the change means * Update text/0007-no-out-of-band-reporting.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com> * Update text/0007-no-out-of-band-reporting.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
carlosalberto
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Nov 8, 2024
…n-telemetry/oteps#26) * Propose: Remove support to report out-of-band telemetry from the API * Clarify what the change means * Update text/0007-no-out-of-band-reporting.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com> * Update text/0007-no-out-of-band-reporting.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.