Merge branch 'main' into add_k8s_volume_type

open-telemetry · Aug 13, 2024 · 62bbbf4 · 62bbbf4
2 parents 6df29d4 + a4fc971
commit 62bbbf4
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/.chloggen/1290.yaml b/.chloggen/1290.yaml
@@ -0,0 +1,4 @@
+change_type: enhancement
+component: db
+note: Change description of `db.client.connection.pending_requests` from cumulative to current value
+issues: [ 1290 ]
diff --git a/docs/attributes-registry/process.md b/docs/attributes-registry/process.md
@@ -15,7 +15,7 @@ An operating system process.
 
 | Attribute                     | Type     | Description                                                                                                                                                                                                                                                                                                                                                 | Examples                                            | Stability                                                        |
 | ----------------------------- | -------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------- | ---------------------------------------------------------------- |
-| `args_count`                  | int      | Length of the process.command_args array [1]                                                                                                                                                                                                                                                                                                                | `4`                                                 | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
+| `process.args_count`          | int      | Length of the process.command_args array [1]                                                                                                                                                                                                                                                                                                                | `4`                                                 | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | `process.command`             | string   | The command used to launch the process (i.e. the command name). On Linux based systems, can be set to the zeroth string in `proc/[pid]/cmdline`. On Windows, can be set to the first parameter extracted from `GetCommandLineW`.                                                                                                                            | `cmd/otelcol`                                       | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | `process.command_args`        | string[] | All the command arguments (including the command/executable itself) as received by the process. On Linux-based systems (and some other Unixoid systems supporting procfs), can be set according to the list of null-delimited strings extracted from `proc/[pid]/cmdline`. For libc-based executables, this would be the full argv vector passed to `main`. | `["cmd/otecol", "--config=config.yaml"]`            | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | `process.command_line`        | string   | The full command used to launch the process as a single string representing the full command. On Windows, can be set to the result of `GetCommandLineW`. Do not set this if you have to assemble it just for monitoring; use `process.command_args` instead.                                                                                                | `C:\cmd\otecol --config="my directory\config.yaml"` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |

diff --git a/docs/database/database-metrics.md b/docs/database/database-metrics.md
@@ -386,7 +386,7 @@ This metric is [recommended][MetricRecommended].
 
 | Name     | Instrument Type | Unit (UCUM) | Description    | Stability |
 | -------- | --------------- | ----------- | -------------- | --------- |
-| `db.client.connection.pending_requests` | UpDownCounter | `{request}` | The number of pending requests for an open connection, cumulative for the entire pool | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
+| `db.client.connection.pending_requests` | UpDownCounter | `{request}` | The number of current pending requests for an open connection | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 
 
 <!-- markdownlint-restore -->

diff --git a/model/metrics/database-metrics.yaml b/model/metrics/database-metrics.yaml
@@ -83,7 +83,7 @@ groups:
     type: metric
     metric_name: db.client.connection.pending_requests
     stability: experimental
-    brief: "The number of pending requests for an open connection, cumulative for the entire pool"
+    brief: "The number of current pending requests for an open connection"
     instrument: updowncounter
     unit: "{request}"
     attributes:

diff --git a/model/registry/process.yaml b/model/registry/process.yaml
@@ -85,7 +85,7 @@ groups:
           executables, this would be the full argv vector passed to `main`.
         examples:
           - ['cmd/otecol', '--config=config.yaml']
-      - id: args_count
+      - id: process.args_count
         type: int
         stability: experimental
         brief: >