Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .NET network + HTTP connection spans #1192

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add .NET network + HTTP connection spans #1192

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9854439
Add .NET HTTP connection spans
lmolkova Jun 27, 2024
1f3e393
up
lmolkova Jun 28, 2024
e772a63
add wait-for-connection and examples
lmolkova Jul 3, 2024
9d0a866
clean up and review
lmolkova Jul 6, 2024
e1bc225
some of the feedback and lint
lmolkova Jul 8, 2024
3376544
more feedback
lmolkova Jul 8, 2024
1d13868
more feedback
lmolkova Jul 8, 2024
f0b43a4
lint
lmolkova Jul 8, 2024
b0b10c0
changelog
lmolkova Jul 8, 2024
46d772f
review
lmolkova Jul 11, 2024
90c3e49
opt in + experimental
lmolkova Jul 11, 2024
e101225
tls names
lmolkova Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chloggen/1192.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
change_type: enhancement
component: dotnet
note: >
Define .NET-specific network spans for DNS resolution, TLS handshake,
and socket connections, along with HTTP-level spans to (optionally) record
relationships between HTTP requests and connections.
issues: [ 1192 ]
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@

# .NET semantic conventions approvers
/model/metrics/dotnet/ @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/model/trace/dotnet/ @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/model/registry/aspnetcore.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/model/registry/signalr.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/docs/dotnet/ @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
Expand Down
7 changes: 4 additions & 3 deletions docs/attributes-registry/dns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@

This document defines the shared attributes used to report a DNS query.

| Attribute | Type | Description | Examples | Stability |
| ------------------- | ------ | --------------------------- | ------------------------------------- | ---------------------------------------------------------------- |
| `dns.question.name` | string | The name being queried. [1] | `www.example.com`; `opentelemetry.io` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| Attribute | Type | Description | Examples | Stability |
lmolkova marked this conversation as resolved.
Show resolved Hide resolved
| ------------------- | -------- | -------------------------------------------- | --------------------------------------------------------- | ---------------------------------------------------------------- |
| `dns.answers` | string[] | The list of resolved IPv4 or IPv6 addresses. | `["10.0.0.1", "2001:0db8:85a3:0000:0000:8a2e:0370:7334"]` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `dns.question.name` | string | The name being queried. [1] | `www.example.com`; `opentelemetry.io` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |

**[1]:** If the name field contains non-printable characters (below 32 or above 126), those characters should be represented as escaped base 10 integers (\DDD). Back slashes and quotes should be escaped. Tabs, carriage returns, and line feeds should be converted to \t, \r, and \n respectively.
8 changes: 4 additions & 4 deletions docs/dotnet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ path_base_for_github_subdir:
to: dotnet/README.md
--->

# Semantic Conventions for .NET metrics
# Semantic Conventions for .NET

**Status**: [Stable][DocumentStatus]
This article documents semantic conventions for metrics and traces emitted by the .NET runtime and individual components in the .NET ecosystem.

This article documents semantic conventions for metrics emitted by the .NET runtime and individual components in the .NET ecosystem.
The following span are currently supported:
- [HTTP client, DNS, and TLS](dotnet-network-traces.md): Semantic Conventions for HTTP client and connection-related *spans*.

The following metrics are currently supported:

Expand All @@ -19,4 +20,3 @@ The following metrics are currently supported:
* [Kestrel](dotnet-kestrel-metrics.md): Semantic Conventions for Kestrel web server *metrics*.
* [SignalR](dotnet-signalr-metrics.md): Semantic Conventions for SignalR server *metrics*.

[DocumentStatus]: https://opentelemetry.io/docs/specs/otel/document-status
Loading
Loading