-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messaging semconv migration guide #1198
base: main
Are you sure you want to change the base?
Messaging semconv migration guide #1198
Conversation
I wonder if it would be easier if we had one (or a few) "migrate from any version" table? I tried to summarize all changes here (but probably missed a thing or two):
|
| `messaging.rocketmq.delivery_timestamp` → `messaging.rocketmq.message.delivery_timestamp` | | | ||
| `messaging.rocketmq.delay_time_level` → `messaging.rocketmq.message.delay_time_level` | | | ||
| `messaging.rocketmq.message_group` → `messaging.rocketmq.message.group` | | | ||
<!-- prettier-ignore-end --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into #1090, it's be nice to mention that we renamed spans and defined a bunch of metrics.
@lmolkova I re-worked the page to provide migrations to the stable version from versions back to 1.16. I think several instrumentations use the old semconv versions so I thought of having this way back further. Took a lot of work, but I think I got everything now :) Everything is mapped in this spreadsheet https://docs.google.com/spreadsheets/d/1evrqe2HfwYbfSfGmXz_O_0iupkFX5lPKrkSBwszfggI/edit?usp=sharing Please take a look to see what you think. Then I will mention/link to the other changes, like span names, new span structure and metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attribute changes look awesome!
I think we need to mention other changes too.
[v1.TODO (stable)](https://github.com/open-telemetry/semantic-conventions/blob/v1.TODO/docs/messaging/README.md). | ||
|
||
### Migrating from v1.26.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably want to mention span name, kind, and metric changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added sections for span name|kind and operation. For metrics, I simply listed the latest "state" as I'm not sure if we should really document all the changes that happened to them.
Fixes #1183
Changes
Migration guide similar to the one done for HTTP, for when the messaging conventions become stable.
Merge requirement checklist
[chore]