Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messaging "Receive", "Deliver", and "Create" operations according to OTEP 220 #284

Merged
merged 23 commits into from
Oct 31, 2023

Conversation

pyohannes
Copy link
Contributor

@pyohannes pyohannes commented Aug 25, 2023

Relates to #198

Changes

This PR brings a first set of changes as outlined in open-telemetry/oteps#220, related to "Receive" operations. Further PRs with other changes will follow.

Main changes:

  • Using links to correlate producer/consumer spans.
  • Add "Create" spans to allow for individual creation contexts for batch publishing.
  • Modelling pull-based (receive) and push-based (deliver) consumer scenarios
  • Remove "Process" spans.
  • Updated span diagrams in the examples.

Merge requirement checklist

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyohannes pyohannes changed the title Update messaging "Receive" operations according to OTEP 220 Update messaging "Receive", "Deliver", and "Create" operations according to OTEP 220 Sep 14, 2023
@pyohannes pyohannes marked this pull request as ready for review September 14, 2023 15:42
@pyohannes pyohannes requested review from a team September 14, 2023 15:42
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial first pass

docs/messaging/messaging-spans.md Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
@pyohannes
Copy link
Contributor Author

All comments/requests should be considered now. @dpauls, @lmolkova @carlosalberto @joaopgrassi please have another look.

docs/messaging/messaging-spans.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Integrate OTEP-0220 Span structure for messaging scenarios into the messaging conventions
8 participants