-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace AWS X-Ray Environment Span Link section #354
Conversation
b427ee3
to
1acf9c3
Compare
For reference, here's the TC decision. (This PR only addresses the first bullet point.)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any ideas for alternative name for xray-env
?
"env" refers to an implementation detail, and doesn't help much with remembering which one to use in which use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitty suggestions
b023c89
to
b77f5f0
Compare
TC decided that users should be able to give priority (controlling the parent/child relationship) to AWS X-Ray's `Active Tracing` span context (as propagated via the `_X_AMZN_TRACE_ID` environment variable) by configuring a different order in the `OTEL_PROPAGATORS`. There is a separate effort to allow span contexts from additional propagators to be added as span links instead of just overwriting them. That will enable this previous behavior to be maintained.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Fix a typo
6e2ae50
to
80240e4
Compare
(To resolve the merge conflict, I rebased on main and moved the changelog entry... the rest of the PR contents are the same.) |
I'm dismissing the "Changes requested". I thought I would point out an obvious defect, but it seems to be a point of much discussion, so I'll assume that I did not fully grasp the problem/proposal.
I think @Oberon00 raises a good question that I hadn't thought about previously, and would like to better understand the implications, especially if this is merged and implemented with the existing composite propagator behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the intent is the update this once the notion of defining intended span links in context is formalized, I approve. Left a few comments to hopefully reduce the context required for readers.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Josh Suereth <joshuasuereth@google.com>
This aligns with the latest spec change: open-telemetry/semantic-conventions#354 Providing the Lambda span's parent context should continue to be the responsibility of the global propagator.
This aligns with the latest spec change: open-telemetry/semantic-conventions#354 Providing the Lambda span's parent context should continue to be the responsibility of the global propagator.
This aligns with the latest spec change: open-telemetry/semantic-conventions#354 Providing the Lambda span's parent context should continue to be the responsibility of the global propagator.
TC decided that users should be able to give priority (controlling the parent/child relationship) to AWS X-Ray's
Active Tracing
span context (as propagated via the_X_AMZN_TRACE_ID
environment variable) by configuring a different order in theOTEL_PROPAGATORS
.There is a separate effort to allow span contexts from additional propagators to be added as span links instead of just overwriting them. That will enable this previous behavior to be maintained.
Here's a POC implementation in Java: open-telemetry/opentelemetry-java-contrib#1032
Note, this POC includes an additional propagator
aws
that handles the behavior for bothxray
andxray-lambda
. This can easily be removed but included as a demonstration.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.Fixes open-telemetry/opentelemetry-specification#3605