Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db.client.operation.duration metric #735

Merged
merged 20 commits into from
Apr 22, 2024

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Feb 13, 2024

Fixes #512

Changes

Adds a new db.client.operation.duration metric with the following attributes:

  • db.system
  • db.collection.name
  • db.name
  • db.operation.name
  • db.instance.id
  • network.peer.address
  • network.peer.port
  • server.address
  • server.port

The metric is a histogram with the following default explicit bucket boundaries (see #735 (comment)): [ 0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5, 10 ]

Merge requirement checklist

@alanwest alanwest force-pushed the alanwest/db-client-call-metric branch from 57534de to 4edbf07 Compare February 13, 2024 00:32
@alanwest alanwest marked this pull request as ready for review February 14, 2024 17:26
@alanwest alanwest requested review from a team February 14, 2024 17:26
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 21, 2024
@trask trask removed the Stale label Mar 26, 2024
@alanwest alanwest changed the title Add db.client.call.duration metric Add db.client.operation.duration metric Apr 8, 2024
model/db-common.yaml Outdated Show resolved Hide resolved
alanwest and others added 2 commits April 8, 2024 13:22
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
model/db-common.yaml Outdated Show resolved Hide resolved
@trask
Copy link
Member

trask commented Apr 19, 2024

@alanwest can you rebase now that #910 has been merged?

docs/database/database-metrics.md Outdated Show resolved Hide resolved
@lmolkova lmolkova merged commit c0e170d into open-telemetry:main Apr 22, 2024
12 checks passed
@alanwest alanwest deleted the alanwest/db-client-call-metric branch April 23, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Database client operation duration metric
6 participants