Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate db.user #894

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Deprecate db.user #894

merged 3 commits into from
Apr 8, 2024

Conversation

trask
Copy link
Member

@trask trask commented Apr 5, 2024 •
edited
Loading

Fixes #885

Changes

Deprecates db.user and removes it from database spans.

@trask trask changed the title Remove db.user Deprecate db.user Apr 5, 2024
@trask trask marked this pull request as ready for review April 5, 2024 14:38
@trask trask requested review from a team April 5, 2024 14:38
@lmolkova lmolkova merged commit a776eaf into open-telemetry:main Apr 8, 2024
12 checks passed
@trask trask deleted the remove-db-user branch October 14, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisch-me trisch-me trisch-me approved these changes

@AlexanderWert AlexanderWert AlexanderWert left review comments

@jack-berg jack-berg jack-berg approved these changes

@pyohannes pyohannes pyohannes approved these changes

@alanwest alanwest alanwest approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees

@jsuereth jsuereth

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove db.user?
8 participants
@trask @AlexanderWert @lmolkova @alanwest @trisch-me @pyohannes @jack-berg @jsuereth