use correct JQuery #92
Conversation
There was a problem hiding this comment.
@jwulf Thanks for the PR! I think the best approach here may be to remove the jQuery dependency altogether in the modal, since Ember is moving away from including it. What do you think about rewiring those bits using CustomEvent?
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ember-bulma", | |||
| "version": "0.0.0-semantically-released", | |||
| "name": "@magikcraft/ember-bulma", | |||
There was a problem hiding this comment.
The name of the package shouldn't be changed. I assume this wasn't intended for this PR but carried over from your personal fork?
| "name": "ember-bulma", | ||
| "version": "0.0.0-semantically-released", | ||
| "name": "@magikcraft/ember-bulma", | ||
| "version": "1.1.0", |
There was a problem hiding this comment.
Also, the version is bumped automatically so no need update this manually.
There was a problem hiding this comment.
Yeah, this was me publishing a package for my own use.
|
|
||
| rules: { | ||
| 'body-leading-blank': [2, 'always'], | ||
| 'body-tense': [0, 'always', ['present-imperative']], |
There was a problem hiding this comment.
It has been removed in the linter upstream. Building with a fresh install via npm wouldn't work with it for me.
At the moment, with 3.13.1 of Ember, jQuery integration in the modal is b0rked. This patch fixes it.