Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup host calls and is-authorized invocation #114

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Sep 13, 2024

  • A.6 Host-call
  • A.8 Argument program invocation
  • B.1 Result constants
  • B.2 Is-authorized invocation

@qiweiii qiweiii marked this pull request as ready for review September 13, 2024 10:58
@@ -0,0 +1,35 @@
public enum HostCallResultConstants {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public enum HostCallResultConstants {
public enum HostCallResultCode: UInt32 {
case none = 0xFFFF_FFFF

can make this a real enum

{
do {
let state = try VMState(standardProgramBlob: blob, pc: pc, gas: gas, argumentData: argumentData)
let engine = Engine(config: DefaultPvmConfig(), hostCallContext: ctx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the config should be passed in

@xlc xlc merged commit 22770dd into master Sep 16, 2024
2 checks passed
@xlc xlc deleted the pvm/host-call-define branch September 16, 2024 07:15
MacOMNI added a commit that referenced this pull request Sep 17, 2024
* 'master' of github.com:AcalaNetwork/boka:
  fix warning (#117)
  keystore (#115)
  setup host calls and is-authorized invocation (#114)
MacOMNI added a commit that referenced this pull request Sep 17, 2024
* master:
  fix warning (#117)
  keystore (#115)
  setup host calls and is-authorized invocation (#114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants