Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve static lib #38

Merged
merged 2 commits into from
Jul 17, 2024
Merged

improve static lib #38

merged 2 commits into from
Jul 17, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Jul 16, 2024 •
edited
Loading

xlc
xlc reviewed Jul 17, 2024
View reviewed changes
.github/workflows/ci.yml Outdated
uses: actions/cache@v4
with:
path: .lib
key: ${{ runner.os }}-libs-${{ hashFiles('.lib/*.a') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work. there are no .a files to hash. not sure if it is possible to use submodule commit as hash key?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to submodule commit hash

@xlc xlc merged commit e7dc080 into master Jul 17, 2024
2 checks passed
@xlc xlc deleted the fix/static-lib-folders branch July 17, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qiweiii @xlc