Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add A.5.8 Instructions #75

Merged
merged 2 commits into from
Aug 26, 2024
Merged

add A.5.8 Instructions #75

merged 2 commits into from
Aug 26, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Aug 23, 2024

No description provided.

@@ -129,6 +132,27 @@ public class Memory {
}
throw Error.notWritable(address)
}

public func sbrk(_ increment: UInt32) throws -> UInt32 {
// TODO: update after memory layout details are implemented
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: need equation 246 to be impl, so we can have correct sbrk

@qiweiii qiweiii requested a review from xlc August 26, 2024 01:13
@qiweiii qiweiii merged commit 49c01e6 into master Aug 26, 2024
2 checks passed
@qiweiii qiweiii deleted the pvm-inst-5.8 branch August 26, 2024 02:08
MacOMNI added a commit that referenced this pull request Aug 28, 2024
* 'master' of github.com:AcalaNetwork/boka:
  add A.5.8 Instructions (#75)
  no need special hanlding for MMR root (#77)
  Hasher refactor (#74)
  header validation (#73)
  Recent history, state merklzation, and db refactor (#72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants