make pairsio.py to read (and, in the future, write) .pairs files #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Phlya
requested changes
Jan 10, 2024
| Additional dataframe with chromosome sizes, if different from regions. | ||
| dist_range : tuple of int, optional | ||
| The range of distances to calculate the scaling curve. Default is (10, 1000000000). | ||
| n_dist_bins : int, optional |
There was a problem hiding this comment.
needs to be updated to n_dist_bins_decade?
There was a problem hiding this comment.
ah, sure! can i update it after merging? :)
|
the indended changes in parseio are complete. In parallel, I've discovered pretty nasty (but yet minor) inconsistencies in the scaling API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, change the API of a couple of functions in scalings.py:
calculate_scalings(n_dist_bins -> n_dist_bins_decade)
norm_scaling(norm_window)