Update tag_residential_loadshifting_assets.yaml #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Electric Vehicle_55 which represents expectations for EV energy demand using the Fit for 55 scenario
Change of description of refrigeration, and add Circulation Pump asset
sandrinecharousset
suggested changes
Jun 9, 2022
| @@ -6,6 +6,8 @@ | |||
| - Residential Load Shifting Asset: | |||
| - Electric Vehicle: | |||
| description: electric vehicles | |||
| - Electric Vehicle_55: | |||
There was a problem hiding this comment.
I would not add a new variable for describing soomething which is the same than the previous variable but for a different ""scenario""; my suggestion would be to use the column "Scenario" i the IAMC format and include there the different scenario names; so I suggest to remove this tag from the nomenclature
There was a problem hiding this comment.
@danielhuppmann do you agree with what I wrote just above?
There was a problem hiding this comment.
Yes, I agree - this is not the intended usage of a variable. Please remove or close this PR and start a new one that has only the changes to the other descriptions.
sandrinecharousset
suggested changes
Jun 23, 2022
Co-authored-by: sandrinecharousset <62063474+sandrinecharousset@users.noreply.github.com>
Co-authored-by: sandrinecharousset <62063474+sandrinecharousset@users.noreply.github.com>
sandrinecharousset
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Electric Vehicle_55 which represents expectations for EV energy demand using the Fit for 55 scenario