Update tag_storage_types.yaml #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment says 'does not include hydro' but Pumped Storage was still included.... which would create variables such as eg Capacity|Electricity|Pumped Storage while the use of Electricity Input creates Capacity|Electricity|Hydro|Pumped storage I propose to remove pumped storage from storage_types
sandrinecharousset
requested review from
erikfilias,
danielhuppmann and
phackstock
|
@sandrinecharousset, I also agree. Because some variables related to storage_type are also defined for pumped-storage hydro. For example: |
erikfilias
approved these changes
May 13, 2024
|
@phackstock could you have a look and merge if ok? |
phackstock
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment says 'does not include hydro' but Pumped Storage was still included.... which would create variables such as eg Capacity|Electricity|Pumped Storage while the use of Electricity Input creates Capacity|Electricity|Hydro|Pumped storage I propose to remove pumped storage from storage_types