Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add non-CO2 emissions in co2e #353

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

robertpietzcker
Copy link
Collaborator

for easier summation checks and finding of cross-model differences, also include the non-CO2 gases at the highest aggregation level in CO2e metric

@robertpietzcker
Copy link
Collaborator Author

@danielhuppmann would it be possible to merge this?

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me to merge here but I don’t think we want to add this in common-definitions…

@danielhuppmann danielhuppmann merged commit d21b58a into openENTRANCE:main Oct 18, 2024
3 checks passed
@robertpietzcker
Copy link
Collaborator Author

Ok for me to merge here but I don’t think we want to add this in common-definitions…

Thanks for merging it here!

why wouldn't you want to have this in common-definitions? I think it is very helpful for plotting, to check consistency of reporting and understand differences between models

@danielhuppmann
Copy link
Member

Well, Emissions|Kyoto Gases|CH4 should be identical to Emissions|CH4 except for the unit, right?
And Emissions|Kyoto Gases|non-CO2 should be Emissions|Kyoto Gases minus Emissions|CO2.

So seems to be duplication of existing variables.

@robertpietzcker robertpietzcker deleted the addEmi branch November 4, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants