fix: remove hardcoded text from XML file (#1258)

openMF · Dec 28, 2019 · 6fbe4f8 · 6fbe4f8
1 parent 75f7c66
commit 6fbe4f8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/app/src/main/res/layout/fragment_review_loan_application.xml b/app/src/main/res/layout/fragment_review_loan_application.xml
@@ -5,6 +5,7 @@
   ~ See https://github.com/openMF/android-client/blob/master/LICENSE.md
   -->
 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     android:background="@color/white"
     android:layout_height="match_parent"
     android:layout_width="match_parent">
@@ -61,7 +62,7 @@
                 android:layout_marginLeft="@dimen/default_padding"
                 android:layout_marginStart="@dimen/default_padding"
                 android:layout_width="match_parent"
-                android:text="Income Generating Loan"
+                android:text="@string/income_generating_loan"
                 android:textAppearance="@style/Base.TextAppearance.AppCompat.Medium" />
 
             <TextView
@@ -82,7 +83,7 @@
                 android:layout_marginLeft="@dimen/default_padding"
                 android:layout_marginStart="@dimen/default_padding"
                 android:layout_width="match_parent"
-                android:text="Not Applicable"
+                android:text="@string/not_applicable"
                 android:textAppearance="@style/Base.TextAppearance.AppCompat.Medium" />
 
             <TextView
@@ -103,7 +104,7 @@
                 android:layout_marginLeft="@dimen/default_padding"
                 android:layout_marginStart="@dimen/default_padding"
                 android:layout_width="match_parent"
-                android:text="143.00"
+                tools:text="@string/dummy_principal_amount"
                 android:textAppearance="@style/Base.TextAppearance.AppCompat.Medium" />
 
 

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -356,6 +356,9 @@
     <string name="add_beneficiary_option">Add Third Party Beneficiaries to your account.\nEither
         enter manually or scan account QR code
     </string>
+    <string name="income_generating_loan">Income Generating Loan</string>
+    <string name="not_applicable">Not Applicable</string>
+    <string name="dummy_principal_amount">143.00</string>
     <string name="invalid_qr">You can\'t make action into your account, please scan other user
         Savings and Loans Account QRCode
     </string>