-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#1432 - Currency Code or Symbol displayed #1433
base: development
Are you sure you want to change the base?
Conversation
ca8f594
to
8611532
Compare
9f017a6
to
26b5510
Compare
26b5510
to
6f1b41d
Compare
@miPlodder Updated the PR for kotlin migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine. But looks more of a backend issue.
Can you share the currency
object for the 2 ss you have attached in the description?
@miPlodder Yes, Sure.
|
is it possible for you to check for Euro as currency? Then only, we can conclude on the fix. |
Currently there are no loans with euro as currency, but I will try. |
@miPlodder I was able to create a loan with euro currency after adding a loan product & it's working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Currency Code or Symbol displayed instead of null values.
Working fine for both country code and symbol.
Fixes #1432
Screenshots:
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.