Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#1432 - Currency Code or Symbol displayed #1433

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

rutvik-panchal
Copy link
Contributor

@rutvik-panchal rutvik-panchal commented Mar 18, 2020

Currency Code or Symbol displayed instead of null values.
Working fine for both country code and symbol.

Fixes #1432

Screenshots:

IMG_20200318_145124 (1)

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@rutvik-panchal rutvik-panchal force-pushed the fix#1432 branch 5 times, most recently from ca8f594 to 8611532 Compare November 29, 2020 12:58
@rutvik-panchal rutvik-panchal changed the base branch from development to master November 29, 2020 15:01
@rutvik-panchal rutvik-panchal changed the base branch from master to development November 29, 2020 15:01
@rutvik-panchal
Copy link
Contributor Author

@miPlodder Updated the PR for kotlin migration.

Copy link
Collaborator

@miPlodder miPlodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. But looks more of a backend issue.
Can you share the currency object for the 2 ss you have attached in the description?

@rutvik-panchal
Copy link
Contributor Author

@miPlodder Yes, Sure.
The currency object for,

  1. First SS with loan number FOVISSSTE000000284 is
    Currency( code=MNT, name=Mongolian Tugrik, decimalPlaces=2.0, inMultiplesOf=1.0, displaySymbol=null, nameCode=currency.MNT, displayLabel=Mongolian Tugrik [MNT] )

  2. Second SS with loan number FOVISSSTE000000293 is
    Currency( code=USD, name=US Dollar, decimalPlaces=2.0, inMultiplesOf=1000.0, displaySymbol=$, nameCode=currency.USD, displayLabel=US Dollar ($) )

@miPlodder
Copy link
Collaborator

is it possible for you to check for Euro as currency? Then only, we can conclude on the fix.

@rutvik-panchal
Copy link
Contributor Author

is it possible for you to check for Euro as currency? Then only, we can conclude on the fix.

Currently there are no loans with euro as currency, but I will try.

@rutvik-panchal
Copy link
Contributor Author

rutvik-panchal commented Dec 16, 2020

@miPlodder I was able to create a loan with euro currency after adding a loan product & it's working fine.
I have checked it.
I am attaching the screenshot and currency object for the same.
Currency(code=EUR, name=Euro, decimalPlaces=2.0, inMultiplesOf=100.0, displaySymbol=€, nameCode=currency.EUR, displayLabel=Euro (€))


Copy link
Contributor

@gururani-abhishek gururani-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null value displayed in place of currency in Loan Summary
4 participants