Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat #840 : Added Support for Reports [with demo API] #855

Closed
wants to merge 2 commits into from
Closed

Feat #840 : Added Support for Reports [with demo API] #855

wants to merge 2 commits into from

Conversation

miPlodder
Copy link
Collaborator

@miPlodder miPlodder commented Jun 3, 2018

Fixes #840

pr_840

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.



@TargetApi(Build.VERSION_CODES.JELLY_BEAN)
public static void requestPermissionFragment(final Fragment fragment,
Copy link
Collaborator Author

@miPlodder miPlodder Jun 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@therajanmaurya Please check this approach and suggest alternatives/improvements.
I have added this so that I can get the PermissionResult Callback in fragment, other method was for Activity.

@miPlodder
Copy link
Collaborator Author

@therajanmaurya Currently, I have not shown anything on Viewing Screen as the actual format .pdf or .xls is not known.

@prashantkh19
Copy link
Contributor

@therajanmaurya We will be working on this issue during this GSoC and my approach is a bit different than this. We would discuss the approach at that time. I think we can leave this PR as of now.

@garvit984
Copy link
Contributor

@miPlodder What should we do about this PR?

@miPlodder
Copy link
Collaborator Author

miPlodder commented Nov 20, 2020

@garvit984 I see this functionality not being implemented yet wrt backend. Let's keep it for reference purposes for future work wrt this functionality.

@edcable We can add it as a Task for this year GSoC if it's still a requirement.

@miPlodder
Copy link
Collaborator Author

Changes look depreciated.
@edcable We add it as a use-case for this year's GSoC.

@miPlodder miPlodder closed this Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for viewing Reports
3 participants