By default, use the xep-daps.xml configuration from stylesheets #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been shipping xep-daps.xml files for a few years with our stylesheets now but never actually used them. This commit aims to change that, because: * using the XEP configuration delivered with the stylesheets, we can make sure we actually use the right fonts and that those fonts are actually installed * we can redefine generic categories like "sans"/"serif" based on the stylesheets we are using and their font dependencies * we can strip down the xep-daps.xml delivered with DAPS to a minimum Note that because of a tiny XML validation issue in suse2013's xep-daps.xml, the new default is incompatible with all suse-xsl-stylesheets packages until 2.0.12. :(
ghost
requested a review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been shipping xep-daps.xml files for a few years with our
stylesheets now but never actually used them. This commit aims to change
that, because:
can make sure we actually use the right fonts and that those
fonts are actually installed
stylesheets we are using and their font dependencies
minimum
Note that because of a tiny XML validation issue in suse2013's
xep-daps.xml, the new default is incompatible with all
suse-xsl-stylesheets packages until 2.0.12. :(
Also, before you say that there is no real issue here today: The xep-daps.xml configuration shipped with DAPS itself for example currently does not support our Korean fonts. The only reason we never noticed is that we normally build Korean documents with FOP and not XEP.