Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for None & len() of ET.Element instead of bool() #1610

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Check for None & len() of ET.Element instead of bool() #1610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions osc/_private/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ def _get_meta_node(self):
raise NotImplementedError()

def get_meta_value(self, option):
if not self._meta_node:
if self._meta_node is None or len(self._meta_node) == 0:
self._meta_node = self._get_meta_node()
if not self._meta_node:
if self._meta_node is None or len(self._meta_node) == 0:
return None
node = api.find_node(self._meta_node, "package", option)
if node is None or not node.text:
Expand Down
Loading