virt.volume_info fixes #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose more functions to handle libvirt storage volumes. virt.volume_infos() expose informations of the volumes, either for one or all the volumes. Among the provided data, this function exposes the names of the virtual machines using the volumes of file type. virt.volume_delete() allows removing a given volume.
Add UT for "is_fqdn" Add "is_fqdn" check to the network utils Bugfix: include FQDNs aliases Deprecate UnitTest assertion in favour of built-in assert keyword Add UT for fqdns aliases Leverage cached interfaces, if any.
Add find_job checks Check if should close on all events Make batch_delay a request parameter Allow multiple event handlers Use config value for gather_job_timeout when not in payload Add async batch unittests Allow metadata to pass Pass metadata only to batch jobs Add the metadata to the start/done events Pass only metadata not all **kwargs Add separate batch presence_ping timeout
If 'fstype' parameter is not set in Linux environments, salt will build a mount command with an empty -t value, making the command fail.
It may happen on pools that have not refresh for a long time that the volume list is not matching reality. Then when calling the info() or XMLDesc() functions libvirt errors out. virt.volume_info() now handles this case. Since the pool and volume parameters can be None, make them optional and default to None.
|
We need to merge this with #129, forcepush 2019.2.0 and update the patch in OBS |
|
@dincamihai any news on this PR? |
|
@cbosdo sorry, this got out of our sight for a while. I'll try to incorporate it today. Thanks for the reminder! |
dincamihai
force-pushed
the
openSUSE-2019.2.0
branch
from
33374e5
to
afcda5d
Compare
|
master-port: saltstack/salt#55165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport saltstack/salt#52033 which is a fix for PR #129