Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virt.pool_capabilities function #189

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Nov 26, 2019

What does this PR do?

Not all storage backends are supported for a given libvirt hypervisor. For the user
to know what is supported and what is not expose the recently added
libvirt function providing pool capabilities.

For older libvirt version, let's craft data that are reasonable by
adding a computed flag to warn these data may not be 100% accurate.

What issues does this PR fix or reference?

Backport of PR saltstack/salt#55346

Tests written?

Yes

Commits signed with GPG?

Yes

Not all storage backends are supported for a given libvirt hypervisor. For the user
to know what is supported and what is not expose the recently added
libvirt function providing pool capabilities.

For older libvirt version, let's craft data that are reasonable by
adding a computed flag to warn these data may not be 100% accurate.
@cbosdo cbosdo force-pushed the openSUSE-2019.2.0-pool-capabilities branch from c35f4d0 to 6035415 Compare December 30, 2019 08:38
@cbosdo
Copy link
Contributor Author

cbosdo commented Dec 30, 2019

@brejoc @meaksh the equivalent upstream PR has been merged. Could you merge this one?

@brejoc
Copy link
Member

brejoc commented Jan 7, 2020

Merged in a541b77

@brejoc brejoc closed this Jan 7, 2020
@cbosdo cbosdo deleted the openSUSE-2019.2.0-pool-capabilities branch January 7, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants