Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ServiceProvider deferred #30

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Make ServiceProvider deferred #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db2fcef
make ServiceProvider deferred
cosmastech Apr 4, 2023
77ed21a
fixes failing arch test suite
cosmastech Apr 4, 2023
18cb756
reverts keyword change
nunomaduro Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace OpenAI\Laravel;

use Illuminate\Contracts\Support\DeferrableProvider;
use Illuminate\Support\ServiceProvider as BaseServiceProvider;
use OpenAI;
use OpenAI\Client;
Expand All @@ -12,7 +13,7 @@
/**
* @internal
*/
final class ServiceProvider extends BaseServiceProvider
final class ServiceProvider extends BaseServiceProvider implements DeferrableProvider
{
/**
* Register any application services.
Expand Down
1 change: 1 addition & 0 deletions tests/Arch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
'Illuminate\Support\ServiceProvider',
'OpenAI\Laravel',
'OpenAI',
'Illuminate\Contracts\Support\DeferrableProvider',

// helpers...
'config',
Expand Down