Add instrumentation for simple convenience chat calls #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Jul 3, 2024
cijothomas
reviewed
Jul 9, 2024
cijothomas
reviewed
Jul 9, 2024
cijothomas
reviewed
Jul 9, 2024
cijothomas
reviewed
Jul 9, 2024
cijothomas
reviewed
Jul 9, 2024
annelo-msft
reviewed
Jul 18, 2024
annelo-msft
reviewed
Jul 18, 2024
lmolkova
force-pushed
the
openai-chat-basic-tracing
branch
from
1fb6b89 to
044cb44
Compare
| // follows OpenTelemetry GenAI semantic conventions: | ||
| // https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai | ||
|
|
||
| public const string ErrorTypeKey = "error.type"; |
There was a problem hiding this comment.
Why don't we have otel APIs that operate on UTF8 strings?
There was a problem hiding this comment.
OTel allows unicode attribute names and uses unicode strings on the wire format.
lmolkova
force-pushed
the
openai-chat-basic-tracing
branch
from
d5e6a06 to
4b25142
Compare
KrzysztofCwalina
approved these changes
Aug 5, 2024
joseharriaga
reviewed
Aug 9, 2024
joseharriaga
reviewed
Aug 9, 2024
lmolkova
force-pushed
the
openai-chat-basic-tracing
branch
from
381b7d3 to
245624a
Compare
joseharriaga
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds foundation for OpenAI SDK tracing and metrics instrumentation (using Otel-compatible .NET primitives).
It's limited to convenience
ChatClientmethods without streaming. The PR implements instrumentation according to OpenTelemetry GenAI semantic conventions.The intention is to add instrumentation to other methods and client types and evolve it along with OTel GenAI semantic conventions.
TODO (in this PR):
TODO (in next PRs):