Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix audio duration types #338

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix audio duration types #338

merged 2 commits into from
Oct 9, 2024

Conversation

RobertCraigie
Copy link
Contributor

@RobertCraigie RobertCraigie mentioned this pull request Oct 1, 2024
Merged
@kwhinnery-openai kwhinnery-openai merged commit d033c36 into openai:master Oct 9, 2024
1 check passed
@mvalkanov
Copy link

Hi @kwhinnery-openai ,
This fix of duration from string to number at CreateTranscriptionResponseVerboseJson and CreateTranslationResponseVerboseJson was merged on Oct 9, but there were later mass updates of openapi.yaml that reverted this change. And duration is again string.
What should be the next steps to fix duration to be number and ensure this is not regressed in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwhinnery-openai kwhinnery-openai kwhinnery-openai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobertCraigie @mvalkanov @kwhinnery-openai