fix:fix response format bug #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattFisher
reviewed
Mar 7, 2023
openai/api_requestor.py
Outdated
Comment on lines
670
to
673
| if self.response_format == ResponseFormat.JSON: | ||
| data = json.loads(rbody) | ||
| else: | ||
| data = rbody |
There was a problem hiding this comment.
I checked and the Content-Type header on the response is always set correctly (at least for the audio transcription responses), so we can deduce whether to json-decode without any other code changes.
For the json and verbose_json response formats, the Content-Type is 'application/json', while for text, srt, and vtt, the Content-Type is 'text/plain; charset=utf-8'`.
Suggested change
| if self.response_format == ResponseFormat.JSON: | |
| data = json.loads(rbody) | |
| else: | |
| data = rbody | |
| if rheaders.get('Content-Type') == 'application/json': | |
| data = json.loads(rbody) | |
| else: | |
| data = rbody |
|
@MattFisher please review in #282, i don't know how i close this PR 😭 |
|
@MattFisher because i force rollback my code so github close this PR automatically,so please review in #282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix this issue:#243