added two new embedding model's encoding #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hauntsaninja Hi, can you check this PR? |
|
Really looking forward to this merge |
zafercavdar
reviewed
Jan 30, 2024
emsi
approved these changes
Feb 1, 2024
|
Thanks for adding these! |
|
Can we merge this to main so I can start using the new models! |
+1 |
|
+1 |
|
+1 |
|
For the meantime you can just: |
This was referenced Feb 7, 2024
|
+1 |
1 similar comment
|
+1 |
|
This has been released in tiktoken 0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Library doesn't support two new embedding model's encoding mapper
text-embedding-3-smalltext-embedding-3-largetiktoken.encoding_for_model("text-embedding-3-small")raises a KeyErrorSolution
Added Encoding mapper for 2 new embedding models. The source of mapping is taken from here