remove auxiliary audio extension #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This is a breaking change but I think it makes sense and will be more compatible to more tools that expect the same basename and different extension |
zackees
pushed a commit
to zackees/whisper
that referenced
this pull request
May 5, 2023
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
leejuyuu
added a commit
to leejuyuu/try-whisper-in-google-collab
that referenced
this pull request
May 15, 2023
Whisper had a breaking change that changes the output extension in openai/whisper#1021. This makes the Colab notebook not working. Fix this by changing the file names.
ilanit1997
pushed a commit
to ilanit1997/whisper
that referenced
this pull request
May 16, 2023
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
abyesilyurt
pushed a commit
to abyesilyurt/whisper
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
'./abc.wav' -> './abc.wav.srt'New:
'./abc.wav' -> './abc.srt'